find sphinx-build before calling build.py #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
sphinx-build-3
branch
2 times, most recently
from
602da62
to
ac2ea6d
Compare
vitaut
requested changes
Oct 13, 2018
doc/CMakeLists.txt
Outdated
| add_custom_target(doc | ||
| COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/build.py ${FMT_VERSION} | ||
| SOURCES api.rst syntax.rst build.py conf.py _templates/layout.html) |
There was a problem hiding this comment.
SOURCES are needed, please keep.
this allows us to use sphinx-build-3, as user might already in a python3 world, and distros, like fedora 28, tend to add a "-3" suffix to sphinx-build. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
there is chance that the distro install python as python3, in that case the shebang of ``` ``` in build.py won't work. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov
force-pushed
the
sphinx-build-3
branch
from
ac2ea6d
to
a74968a
Compare
|
@vitaut Victor, thanks for your review. fixed and repushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows us to use sphinx-build-3, as user might already in a python3
world, and distros, like fedora 28, tend to add a "-3" suffix to sphinx-build.
Signed-off-by: Kefu Chai tchaikov@gmail.com