Add support to compile time non-char format #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Oct 27, 2018
| inline typename std::enable_if<is_compile_string<S>::value, string_view>::type | ||
| to_string_view(const S &s) { return {s.data(), s.size() - 1}; } | ||
| template <typename S, typename Enable = typename std::enable_if<is_compile_string<S>::value>::type> | ||
| inline auto to_string_view(const S &s) -> basic_string_view<typename S::char_type> { |
There was a problem hiding this comment.
Is there any reason to move enable_if from return type to template parameter?
There was a problem hiding this comment.
I am not sure if it is possible to use S::char_type inside enable_if since S may not satisfy is_compile_string, so I choose my familiar way to implement this.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #922