Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibilities with c++2a mode in clang #933

Merged
merged 1 commit into from
Nov 17, 2018

Conversation

christinaa
Copy link

This closes #932.

@christinaa
Copy link
Author

Minor correction, it was a fundamental type as-is but was gated behind an option. Since Clang 346892 it is now enabled by default.

This makes use of a rather simple feature test:

Builder.defineMacro("__cpp_char8_t", "201811L");

@vitaut vitaut merged commit 16b78ee into fmtlib:master Nov 17, 2018
@vitaut
Copy link
Contributor

vitaut commented Nov 17, 2018

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in Clang (r346892) with C++2a
2 participants