Add support for builtin terminal colors. #974
Conversation
|
gcc 4.4 is unhappy because it doesn't support unrestricted unions. |
| FMT_CONSTEXPR color_type() FMT_NOEXCEPT | ||
| : is_rgb(), value{} {} | ||
| FMT_CONSTEXPR color_type(color rgb_color) FMT_NOEXCEPT | ||
| : is_rgb(true), value{} { |
There was a problem hiding this comment.
Why call value{} if it is initialized below?
There was a problem hiding this comment.
That was some another attempt to fix gcc 4.4 that we don't need anymore :). I'll remove it.
There was a problem hiding this comment.
@vitaut Nevermind my previous comment. They are initialized because they have to be for constexpr and it seems like VS2013 doesn't implement directly initializing the union in a member initializer list. So I have to leave it like it is :(
Rakete1111
force-pushed
the
terminal-color
branch
from
53c5264
to
d72b67e
Compare
|
Merged, thanks! |
|
@Rakete1111, could you please review the updated CONTIBUTING document, particularly the part about licensing, and let me know if you agree with it being applied both to your contributions to {fmt}? The library is likely to be relicensed (#1073) so I'm collecting approval from all earlier contributors. Thanks! |
Fixes #968. This PR adds a
terminal_colorenum:fmt::print(fg(fmt::terminal_color::red), "stop\n");