Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected rowset deduplicators DISTINCT and ALL #1380

Merged
merged 7 commits into from
Jan 26, 2025
Merged

Corrected rowset deduplicators DISTINCT and ALL #1380

merged 7 commits into from
Jan 26, 2025

Conversation

trueqbit
Copy link
Collaborator

  • Fixed the missing ability to write distinct(struct_<>()).
  • Corrected serialization of DISTINCT/ALL: They don't introduce a parenthesized context.
  • Added Unit Tests.
  • Moved rowset deduplicators to the syntax tree. Previously, the DISTINCT/ALL result set deduplicators were stored as a member flag (i.e. runtime value) in columns_t and struct_t. I moved it to the AST because it is part of the logical structure of an SQL select expression.
  • The previous point also fixes collecting column names.

@trueqbit
Merge branch 'upstream/dev' into distinct_struct_
b8fe04d
@trueqbit
Corrected distinct/all result set modifiers
91c036d 
* `distinct(struct<>())` was missing.
* Corrected streaming of DISTINCT/ALL; they must not parenthesize expressions following those result set modifiers.
* Created unit tests for distinct/all.
@trueqbit
Moved rowset deduplicator to the syntax tree
07af008 
* Previously, the DISTINCT/ALL result set deduplicator was stored as a member flag (i.e. runtime value) in `columns_t` and `struct_t`. I moved it to the AST because it is part of the logical structure of an SQL select expression.
* Corrected UT for `distinct(glob())`.
* Added a UT for distinct in an aggregate function, `count(distinct())`.
@trueqbit
Adjusted the name of the template parameter for the serialization con…
68c796b 
…text
@trueqbit
consteval implies inline
fd10847
@trueqbit
Merge branch 'upstream/dev' into corrected_rowset_deduplicators
97486f8
@trueqbit trueqbit linked an issue Jan 25, 2025 that may be closed by this pull request
Select distinct with return struct results in extra parenthesis #1341
Closed
@trueqbit trueqbit requested a review from fnc12 January 25, 2025 19:43
fnc12
fnc12 approved these changes Jan 26, 2025
View reviewed changes
@trueqbit trueqbit merged commit 5e21e5a into dev Jan 26, 2025
3 checks passed
@trueqbit trueqbit deleted the corrected_rowset_deduplicators branch January 26, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnc12 fnc12 fnc12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select distinct with return struct results in extra parenthesis
2 participants
@trueqbit @fnc12