Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDS improvements #184

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

CDS improvements #184

wants to merge 4 commits into from

Conversation

delabassee
Copy link
Contributor

  1. By default, the CDS shared archive is installed with the JRE (1). Despite that, we are regenerating this CDS archive with RUN ["/usr/bin/java", "-Xshare:dump"]. So and unless I'm missing something, this is not needed.
  2. According to the doc (2), CDS is enabled by default on Java 11 so there's no need to enable it with -Xshare:on.

(1) https://docs.oracle.com/en/java/javase/11/vm/class-data-sharing.html#GUID-EC975B2E-B4AB-45B4-B91F-51C3A264D0CE

(2) https://docs.oracle.com/en/java/javase/11/vm/class-data-sharing.html#GUID-882DC523-706D-403E-8A06-FBBB0E1B2128

@delabassee
Copy link
Contributor Author

Do not merge yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zootalures zootalures Awaiting requested review from zootalures

@rikgibson rikgibson Awaiting requested review from rikgibson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@delabassee