Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Screen Cover Feature #37

Open
tyler-dane opened this issue Aug 5, 2021 · 1 comment
Open

Remove Screen Cover Feature #37

tyler-dane opened this issue Aug 5, 2021 · 1 comment
Assignees

Comments

@tyler-dane
Copy link
Member

tyler-dane commented Aug 5, 2021

After fixing the screen cover bug (#33 & #36), I tried enabling it and am confused what it's supposed to do. It currently just tints my screen blue. Is that the whole feature? What is the point?

There are also some other complications:

  • It creates another persistent notification, similar to Remove 'Focus Launcher is running' notification #24 (see screenshot below)
  • The notification has the old Siempo logo.
  • Some buttons don't work when it's enabled. For example:
    • I tried taking a screenshot and uploading it to Google Photos
    • But clicking the 'Upload' button didn't do anything
    • I had to disable the overlay before the Google Photos Upload button worked

Investigate what the feature is intended to do an let's discuss what to do with it going forward.
screenshot

@tyler-dane tyler-dane changed the title Screen Overlay Discussion Screen Cover Discussion Sep 3, 2021
@tyler-dane tyler-dane changed the title Screen Cover Discussion Remove Screen Cover Feature Sep 3, 2021
@tyler-dane
Copy link
Member Author

Spoke with Siempo's Co-Founder and confirmed that this was an experimental feature that wasn't intended to be in mainline code. They were apparently testing out different overlays for the reduce app usage feature. I'd suggest removing this to avoid confusing users

@bhanup212 bhanup212 self-assigned this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants