Fix focus not always returning to expected element on active=false #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new fix for the issue identified in #54 after gaining a better understanding of the issue. The `returnFocusOnDeactivate` flag was being special-cased, but not always, and the element to which focus should be returned, which focus-trap-react attempts to manage on its own (see class Constructor comment for reasoning), was not always correct. For example, if the trap was deactivated, and then re-activated, the 'last focused element before activation' wasn't updated at the moment of re-activation, where it could've changed.
🦋 Changeset detectedLatest commit: 86b464f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@maraisr What do you think about this? The issue is related to how this library special-cases the returnFocusOnDeactivate flag. |
|
Ill take look tomorrow morning @stefcameron |
maraisr
approved these changes
Oct 14, 2020
|
See more discussion on #54. Looks like this solution will work. Merging. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new fix for the issue identified in #54 after gaining
a better understanding of the issue.
The
returnFocusOnDeactivateflag was being special-cased, butnot always, and the element to which focus should be returned,
which focus-trap-react attempts to manage on its own (see
class Constructor comment for reasoning), was not always correct.
For example, if the trap was deactivated, and then re-activated,
the 'last focused element before activation' wasn't updated at
the moment of re-activation, where it could've changed.
Features and Bug Fixes
Prop-types added/updated.Typings added/updated.README updated (API changes, instructions, etc.).Changes to dependencies explained.yarn changesetlocally to add one, follow prompts).