Fix multiple issues surrounding trap deactivation #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consistently call onDeactivate, onPostDeactivate, checkCanReturnFocus These options were not being called consistently, particularly because of the way focus-trap-react tries to participate in the trap's deactivation process in order to control how focus is returned (if the trap is configured to return focus after deactivation). - Ensure an outside click permitted to deactivate the trap with the `clickOutsideDeactivates=true` option is actually permitted to so _and_ focus remains on the outside node clicked rather than returning to the node that had focus prior to the trap being activated (which is the default behavior). - Required bump to focus-trap v6.9.0 for bug fixes and new features to help with above fixes.
🦋 Changeset detectedLatest commit: 05e795a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #659 +/- ##
==========================================
- Coverage 95.20% 93.33% -1.87%
==========================================
Files 1 1
Lines 125 150 +25
Branches 50 63 +13
==========================================
+ Hits 119 140 +21
- Misses 6 10 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options were not being called consistently, particularly because
of the way focus-trap-react tries to participate in the trap's
deactivation process in order to control how focus is returned
(if the trap is configured to return focus after deactivation).
Ensure an outside click permitted to deactivate the trap with the
clickOutsideDeactivates=trueoption is actually permitted to soand focus remains on the outside node clicked rather than returning
to the node that had focus prior to the trap being activated (which
is the default behavior).
Required bump to focus-trap v6.9.0 for bug fixes and new features
to help with above fixes.
PR Checklist
Please leave this checklist in your PR.
typeof document/window !== 'undefined'before using it in code that gets executed on load.yarn changesetlocally to add one, and follow the prompts).