Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux install fails #1

Open
spencergilbert opened this issue May 2, 2020 · 13 comments
Open

Linux install fails #1

spencergilbert opened this issue May 2, 2020 · 13 comments

Comments

@spencergilbert
Copy link

Looking at the code it looks like "amd64" is appended to all os names to build the download URL, but the releases for linux are simply named "jq-linux64" (for current release, older releases have a different naming scheme as well)

@yssource
Copy link

yssource commented May 9, 2020

https://github.com/stedolan/jq/releases/download/jq-1.6/jq-linux-amd64

curl: (22) The requested URL returned error: 404 Not Found
Error: jq version jq-1.6 not found

@AZMCode
Copy link

AZMCode commented May 24, 2020

It also seems, as far as i can tell, that the naming conventions of these releases have never quite been consistent, but most importantly I can't find a linux release which uses the amd64 suffix, which means it has always been broken for linux.

Because of the inconsistencies in naming conventions we need a very much more smart way to pick between the various releases.

What's more is 1.0, 1.1, and 1.2 just provide the source, while the plugin still lists them as installable releases, which means the plugin has been broken for all of those releases, always.

Edit: Oh God I've just realized, to do any sort of smarter version selection, we'd need to parse Github's JSON api... Ironic.

Edit²: Working on a fix to put in a pull request. Should be ready tomorrow hopefully maybe.

AZMCode referenced this issue in AZMCode/asdf-jq May 25, 2020
The plugin can now select between various files available in a release in a smarter way.
Fixes #1
@AZMCode
Copy link

AZMCode commented May 25, 2020

Also, how did the Ubuntu test not catch anything?

@AZMCode
Copy link

AZMCode commented Jun 27, 2020

Any progress on merging?

@AZMCode
Copy link

AZMCode commented Jul 7, 2020

To use the fixed version while this issue is resolved run:

asdf plugin add jq https://github.com/AZMCode/asdf-jq.git
asdf plugin update jq patch-1

@RafalSkolasinski
Copy link

RafalSkolasinski commented Aug 10, 2020

Is this by any chance related to asdf-vm/asdf#756?
Trying to install jq with asdf (on linux) keeps giving:

rskolasinski@machine42:~$ asdf install jq latest
jq  is already installed

@AZMCode
Copy link

AZMCode commented Aug 10, 2020

I'll try to filter out the jq part of the release names

@AZMCode
Copy link

AZMCode commented Aug 10, 2020

Just updated my PR to filter out jq- from the beginning of the release names

@AZMCode
Copy link

AZMCode commented Aug 10, 2020

@RafalSkolasinski
It kind of isn't, but is another whole bug into itself

@AZMCode
Copy link

AZMCode commented Aug 10, 2020

Also, I remember somewhere about an actions bug referring to ;; in a switch statement in a bash script in Mac os, but I can't find it.
It's affecting my PR.
Appreciate if any of y'all know

@chrislegault
Copy link

@AZMCode this commit in another fork fixed my issues on mac, tayler-jones@afb0be6 maybe you can see if something in there will help

@AZMCode
Copy link

AZMCode commented Aug 10, 2020

Sure, thanks!

@AZMCode
Copy link

AZMCode commented Dec 8, 2020

Made #9, shich should fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants