Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change constructor to public #3

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Change constructor to public #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- All implementations of Data are now `readonly`
- KeyedData constructor changed from `private` to `public`

## [1.2.0] 2023-11-11

Expand Down
2 changes: 1 addition & 1 deletion src/KeyedData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public static function tryFrom(mixed $value): self
);
}

private function __construct(
public function __construct(
private array|object $value = new stdClass(),
) {
}
Expand Down
2 changes: 1 addition & 1 deletion tests/KeyedDataTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public static function unsupportedValues(): array

public function testFromShouldCreateInstance(): void
{
$data = KeyedData::from(self::$fixture);
$data = new KeyedData(self::$fixture);

self::assertInstanceOf(
expected: KeyedData::class,
Expand Down