Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop into main for version 2.0.0 #4

Merged
merged 4 commits into from
Nov 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.0.0] 2023-11-15

### Changed

- All implementations of Data are now `readonly`
- KeyedData constructor changed from `private` to `public`

## [1.2.0] 2023-11-11

### Added
Expand Down
2 changes: 1 addition & 1 deletion src/DataProxy.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace Focus\Data;

abstract class DataProxy implements Data
abstract readonly class DataProxy implements Data
{
abstract protected function source(): Data;

Expand Down
2 changes: 1 addition & 1 deletion src/JsonData.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

use const JSON_THROW_ON_ERROR;

final class JsonData extends DataProxy
final readonly class JsonData extends DataProxy
{
use DataProxyBehavior;

Expand Down
2 changes: 1 addition & 1 deletion src/KeyedData.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public static function tryFrom(mixed $value): self
);
}

private function __construct(
public function __construct(
private array|object $value = new stdClass(),
) {
}
Expand Down
2 changes: 1 addition & 1 deletion tests/KeyedDataTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public static function unsupportedValues(): array

public function testFromShouldCreateInstance(): void
{
$data = KeyedData::from(self::$fixture);
$data = new KeyedData(self::$fixture);

self::assertInstanceOf(
expected: KeyedData::class,
Expand Down
2 changes: 1 addition & 1 deletion tests/ProxiesData.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use Focus\Data\Behavior\DataProxyBehavior;
use Focus\Data\DataProxy;

final class ProxiesData extends DataProxy
final readonly class ProxiesData extends DataProxy
{
use DataProxyBehavior;
}