Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EC2 Container Service #120

Merged
merged 2 commits into from
Jun 17, 2015

Conversation

nomadium
Copy link
Contributor

This implements Amazon EC2 Container Service support for fog.

@nomadium
Copy link
Contributor Author

I'm also providing some scripts to verify this works OK. I took the task definition and service demos provided in AWS documentation and uploaded them with my scripts to a gist: https://gist.github.com/nomadium/afd6fb412a2b41ff6ecc.

@nomadium nomadium force-pushed the add-support-for-ecs branch 2 times, most recently from bf46aae to 312e7a1 Compare May 31, 2015 00:10
@geemus
Copy link
Member

geemus commented Jun 1, 2015

Looks like there are some related test failures, could you dig in there? Just let me know if you have questions or anything I can help with. Thanks!

@nomadium
Copy link
Contributor Author

nomadium commented Jun 1, 2015

Hi @geemus, yep I'm reviewing those issues during this week. I'll ping you again when I fix all Travis failures. Thanks!

@geemus
Copy link
Member

geemus commented Jun 1, 2015

Great, thanks for the update. Just let me know if you have any questions or
anything I can help with. Thanks!

On Mon, Jun 1, 2015 at 4:06 PM, Miguel Landaeta notifications@github.com
wrote:

Hi @geemus https://github.com/geemus, yep I'm reviewing those issues
during this week. I'll ping you again when I fix all Travis failures.
Thanks!

Reply to this email directly or view it on GitHub
#120 (comment).

@nomadium
Copy link
Contributor Author

nomadium commented Jun 5, 2015

@geemus Hi! I think I'm going to need help with this PR. I having problems with some mocks and tests, sometimes they succeed and sometimes one or more of them fail. I don't know if I'm running into a race condition or something. I implemented them in similar way to another Fog mocks, (i.e. I prepare a valid response for any given request and I save any needed object in self.data to be used for subsequent requests).

I noticed that for some failed mocked requests if I catch exceptions and retry, some of them succeed but this smells like a hack and doesn't work on all cases.

I'm kinda lost about debugging this, any recommendation?

@nomadium
Copy link
Contributor Author

nomadium commented Jun 5, 2015

I finally saw my mistake with delete_cluster tests and that gave me a clue about some how to fix the rest of the failing tests. I'll debug them and I'll come back later.

@nomadium
Copy link
Contributor Author

nomadium commented Jun 6, 2015

@geemus I finally got the tests passing so you can review the code whenever you want. Thanks!

@hosh
Copy link

hosh commented Jun 11, 2015

@nomadium I've been using your branch of the code, and it's helped a ton. Thanks for putting this together! 👍

@geemus
Copy link
Member

geemus commented Jun 12, 2015

Awesome, travelling this week for work, so falling behind a bit on review tasks, but hope to get back to this soon.

@geemus
Copy link
Member

geemus commented Jun 17, 2015

Apologies again for delays, looks great, thanks!

geemus added a commit that referenced this pull request Jun 17, 2015
Add support for EC2 Container Service
@geemus geemus merged commit 87c8c64 into fog:master Jun 17, 2015
@nomadium
Copy link
Contributor Author

@geemus Awesome, thank you for reviewing it and merging it.

@nomadium nomadium deleted the add-support-for-ecs branch June 18, 2015 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants