-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EC2 Container Service #120
Conversation
I'm also providing some scripts to verify this works OK. I took the task definition and service demos provided in AWS documentation and uploaded them with my scripts to a gist: https://gist.github.com/nomadium/afd6fb412a2b41ff6ecc. |
bf46aae
to
312e7a1
Compare
Looks like there are some related test failures, could you dig in there? Just let me know if you have questions or anything I can help with. Thanks! |
Hi @geemus, yep I'm reviewing those issues during this week. I'll ping you again when I fix all Travis failures. Thanks! |
Great, thanks for the update. Just let me know if you have any questions or On Mon, Jun 1, 2015 at 4:06 PM, Miguel Landaeta notifications@github.com
|
312e7a1
to
0d83999
Compare
@geemus Hi! I think I'm going to need help with this PR. I having problems with some mocks and tests, sometimes they succeed and sometimes one or more of them fail. I don't know if I'm running into a race condition or something. I implemented them in similar way to another Fog mocks, (i.e. I prepare a valid response for any given request and I save any needed object in I noticed that for some failed mocked requests if I catch exceptions and retry, some of them succeed but this smells like a hack and doesn't work on all cases. I'm kinda lost about debugging this, any recommendation? |
I finally saw my mistake with |
4908bab
to
a8ea5e3
Compare
@geemus I finally got the tests passing so you can review the code whenever you want. Thanks! |
@nomadium I've been using your branch of the code, and it's helped a ton. Thanks for putting this together! 👍 |
Awesome, travelling this week for work, so falling behind a bit on review tasks, but hope to get back to this soon. |
Apologies again for delays, looks great, thanks! |
Add support for EC2 Container Service
@geemus Awesome, thank you for reviewing it and merging it. |
This implements Amazon EC2 Container Service support for fog.