make elb/policies collection standalone #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanej
changed the title
* there is no need to inject data from the load balancer model when an index request exists that maps directly
ey-pairing
force-pushed
the
elb-policy-collection
branch
from
b2b46d0
to
cdd724d
Compare
| def load_balancer | ||
| collection.load_balancer | ||
| service.load_balancers.new(identity: collection.load_balancer_id) |
There was a problem hiding this comment.
Could you fix the 1.8 incompatible named argument here? Hopefully we'll reach a point where we can drop 1.8 soon, but not quite ready for the major/breaking change I'm afraid. Thanks!
There was a problem hiding this comment.
Yeah, stuff like this is starting to bite us more and more often. Breaking changes just also are, well, breaking, so caution prevails. Would love to cut it out soon though.
There was a problem hiding this comment.
it's the last "," before the end of a Hash definition that is perhaps the biggest annoyance. Quite possible the most understated Ruby improvement.
* fix 1.9 only syntax * don't rely on possible collection for a required attribute
* pull load_balancer_id from the collection and set on the model
geemus
added a commit
that referenced
this pull request
Jun 1, 2015
make elb/policies collection standalone
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an index request exists that maps directly