Disable idempotent option when block is passed to get_object #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Looks good to me |
|
Looks good, thanks! |
geemus
added a commit
that referenced
this pull request
Sep 16, 2015
…treaming Disable idempotent option when block is passed to get_object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idempotent option can be problematic when calling get_object with a streaming block since Excon automatically retries the entire request from the beginning when something goes wrong, without making it clear that it's doing so. This can result in lots of issues, including data corruption. In order to prevent this, I'd like to propose that we disable the idempotent option whenever a streaming block is provided to get_object.
Original Issue: #181