Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log warning message about when not on us-region #200

Merged
merged 4 commits into from
May 20, 2016
Merged

Add log warning message about when not on us-region #200

merged 4 commits into from
May 20, 2016

Conversation

kitofr
Copy link
Contributor

@kitofr kitofr commented Nov 20, 2015

  • Non us-regions are not supported for mocks. Added message

- Non us-regions are not supported for mocks. Added message
@geemus
Copy link
Member

geemus commented Nov 23, 2015

The error raised here is intended to be inline with the behavior you would see in live usage (I think). Maybe it would be better to use Fog.warning and leave the error unchanged? What do you think?

@kitofr
Copy link
Contributor Author

kitofr commented Nov 24, 2015

That sounds like a fair solution. I merely wanted to get some heads up about the region problem whilst using Mocks.
I'll see if I can change it to use Fog.warning instead.

@geemus
Copy link
Member

geemus commented Nov 24, 2015

Sounds good, thanks!

@lanej
Copy link
Member

lanej commented May 19, 2016

@kitofr please rebase off of master

@kitofr kitofr changed the title Add message Add log warning message about when not on us-region May 20, 2016
@lanej lanej merged commit 5e463ed into fog:master May 20, 2016
@geemus
Copy link
Member

geemus commented May 20, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants