restore db instance fom db snapshot #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ehowe
commented
Jan 19, 2016
ehowe
commented
- add mock
- add restore method on servers collection
- modify save method on server model
- raise error when multi_az and az are set
- cannot specify multi_az to be true and pick an az together
- take allocated_storage from snapshot on restore
- restore from snapshot endpoint does not take
- allocated_storage parameter
- save storage type on rds snapshot
* add mock * add restore method on servers collection * modify save method on server model * raise error when multi_az and az are set * cannot specify multi_az to be true and pick an az together * take allocated_storage from snapshot on restore * restore from snapshot endpoint does not take * allocated_storage parameter * save storage type on rds snapshot
|
Not sure whats up with the specs, every time I fix something, something else breaks. Is this a known issue? |
| @@ -3,6 +3,18 @@ module DNS | |||
| class AWS < Fog::Service | |||
| extend Fog::AWS::CredentialFetcher::ServiceMethods | |||
|
|
|||
| require 'fog/aws/requests/dns/change_resource_record_sets' | |||
There was a problem hiding this comment.
These should be redundant to the request calls that come a bit later (though a couple new ones should be added). By using request the requires are deferred, however, until initialization time. So, I think we just want the request versions and not these explicit requires.
|
Looks good overall, added a couple more specific items of feedback above. Thanks! |
|
Thanks! |
geemus
added a commit
that referenced
this pull request
Jan 25, 2016
restore db instance fom db snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.