autoscaler attach/detatch

[shaiguitar]

Ran this against a live amazon account and this did the expected.

Amazon doc links inline in the commit.

[shaiguitar]

/cc @lanej

[lanej]

should be http://docs.aws.amazon.com/AutoScaling/latest/APIReference/API_AttachInstances.html

[shaiguitar]

pushed doc link change

[lanej]

i'll worry about the version bump, tagging, etc.

[shaiguitar]

reverted lib/version.rb change to what it was

[geemus]

@lanej looks like you are on top of this, but just let me know if you need anything.

[lanej]

@geemus thanks

[lanej]

@shaiguitar the mocks don't manipulate any data. is that intentional ?

[shaiguitar]

@lanej Basically just copied over what was in https://github.com/fog/fog-aws/blob/master/lib/fog/aws/requests/auto_scaling/attach_load_balancers.rb#L36-L55 . There's no documentation/wiki on adding mock behavior and it's been a while so I'm a little hazy on the idiomatics.

Seems like the asg mock interactions are broken as well with regards to the other instance manipulation requests, see these two (Fog::Mock.not_implemented) lib/fog/aws/requests/auto_scaling/set_instance_health.rb and lib/fog/aws/requests/auto_scaling/terminate_instance_in_auto_scaling_group.rb

In the case of lib/fog/aws/requests/auto_scaling/set_desired_capacity.rb if we reload after setting desired capacity it should also create some instances, but nothing is happening in the mock either.

There's probably some other examples but that should be an indication it's not quite there for the asgs anyway.

So, I can add another not_implemented in there or I can take a look at implementing these mocks, but I'll need some hand holding and or docs/wiki.

[shaiguitar]

Bump. The real implementation should work. I can add in not_implemented if that's better than the current alternative

[shaiguitar]

Anything I can do to get this released?

[lanej]

@shaiguitar rebase for a passing build

[shaiguitar]

@lanej green

[shaiguitar]

Thanks!

[lanej]

@shaiguitar this commit screwed with the versions @2456533f029698f060f4c368af22d9106d74b64f. Next time remove the commit instead of reverting in the same branch.