support for rds clusters and aurora #230
Conversation
ehowe
commented
Feb 26, 2016
ehowe
commented
- add db cluster identifier to db instance parser
- dont allow setting security groups on aurora instances
- aurora instances do not support the multi az parameter due to the cluster
- aurora has its own storage type that cannot be set
| @@ -47,7 +47,7 @@ def modify_db_instance(db_name, apply_immediately, options={}) | |||
|
|
|||
| class Mock | |||
| def modify_db_instance(db_name, apply_immediately, _options={}) | |||
| options = _options | |||
| options = _options.dup | |||
|
@ehowe can you put the links to the docs in the request files? (make it pretty). |
|
@lanej done |
| end | ||
|
|
||
| def master | ||
| db_cluster_members.detect { |member| member["master"] } |
There was a problem hiding this comment.
unfortunate thing about the master and replicas methods is that you have inflate the entire list (1 call per member) and then filter. not a blocker but definitely room for a performance enhancement.
|
@ehowe looks like you have on legitimate failure https://travis-ci.org/fog/fog-aws/jobs/112850945. I need to spend some time fixing the |
|
@lanej fwiw, I think fog-openstack just fixed it (they just created a separate Gemfile for 1.9.x and added mime-types with a different locked version I believe). So can probably just follow their lead. |
|
@geemus ill take a look |
|
@lanej thanks, will do |
* add db cluster identifier to db instance parser * dont allow setting security groups on aurora instances * aurora instances do not support the multi az parameter due to the cluster * aurora has its own storage type that cannot be set
|
@lanej green build finally |
support for rds clusters and aurora
|
Thanks! On Thu, Mar 3, 2016 at 3:58 PM, Josh Lane notifications@github.com wrote:
|
