Add PlacementTenancy to launch configuration parser and test case #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to add a test case for this, but I'm not quite sure where. Should it go in https://github.com/fog/fog-aws/blob/master/tests/requests/auto_scaling/model_tests.rb#L12 ?? |
|
Good question. I'm not sure there is a particularly good place for it (and it should be a fairly safe change). We can discuss more, but for simplicity I'm going to just pull this in for now. Thanks! |
geemus
added a commit
that referenced
this pull request
Jan 26, 2015
Add PlacementTenancy to launch configuration parser and test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if I should update any part to conform with coding standards etc.