Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some missing parts in change sets #322

Merged
merged 2 commits into from
Nov 29, 2016

Conversation

nilroy
Copy link
Contributor

@nilroy nilroy commented Nov 24, 2016

This PR solves the following:

  1. Get the status of cloudformation change set creation
  2. Create change set for stacks that changes IAM roles/policies

@nilroy
Copy link
Contributor Author

nilroy commented Nov 24, 2016

@lanej @geemus Its a very small PR..Please review

@nilroy nilroy changed the title Modified the parser so that it can parse the Status filed while describing a change set Fixed some missing parts in change sets Nov 25, 2016
@nilroy
Copy link
Contributor Author

nilroy commented Nov 28, 2016

@geemus This PR is ready. It's pretty straightforward

@geemus
Copy link
Member

geemus commented Nov 29, 2016

LGTM, will leave for @lanej to double-check and merge.

@lanej lanej merged commit 627ba26 into fog:master Nov 29, 2016
@lanej
Copy link
Member

lanej commented Nov 29, 2016

Thanks @nilroy.

@nilroy
Copy link
Contributor Author

nilroy commented Nov 29, 2016

@lanej thanks a lot. When can we expect the new gem version?

@lanej
Copy link
Member

lanej commented Nov 29, 2016

https://rubygems.org/gems/fog-aws/versions/0.13.0

@nilroy
Copy link
Contributor Author

nilroy commented Nov 30, 2016

@lanej Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants