fix default_security_group detection

[lanej]

Match on the correct description.

Fixes #347

[lanej]

Moving default security group creation to create_vpc solves only half the problem. Security groups are currently stored in a hash with the key being the name. However, security group name is not unique.

<Fog::Compute::AWS::SecurityGroup
        name="default",
        description="default VPC security group",
        group_id="sg-2c2dfc56",
        ip_permissions=[{"groups"=>[{"userId"=>"362331042830", "groupId"=>"sg-2c2dfc56"}], "ipRanges"=>[], "ipProtocol"=>"-1"}],
        ip_permissions_egress=[{"groups"=>[], "ipRanges"=>[{"cidrIp"=>"0.0.0.0/0"}], "ipProtocol"=>"-1"}],
        owner_id="362331042830",
        vpc_id="vpc-a25b26c5",
        tags={}
      >,
<Fog::Compute::AWS::SecurityGroup
        name="default",
        description="default VPC security group",
        group_id="sg-39706345",
        ip_permissions=[{"groups"=>[{"userId"=>"362331042830", "groupId"=>"sg-39706345"}], "ipRanges"=>[], "ipProtocol"=>"-1"}],
        ip_permissions_egress=[{"groups"=>[], "ipRanges"=>[{"cidrIp"=>"0.0.0.0/0"}], "ipProtocol"=>"-1"}],
        owner_id="362331042830",
        vpc_id="vpc-a6136bc0",
        tags={}
      >,

I will overhaul the mock security group storage but it will be a substantial change.

[lanej]

I've finished overhauling the (tested) mock files to key off of groupId rather than groupName.

[geemus]

👍 looks good to me, thanks for checking in

[geemus]

Thanks!

…

On Thu, Nov 9, 2017 at 9:47 AM, Josh Lane ***@***.***> wrote: Merged #348 <#348>. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#348 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAQKmC56yWmE2Hg6R2pfp2PxTg2tbedks5s0x6jgaJpZM4MLtKC> .