Modify volume #350
Merged
Modify volume #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2017 13:34
|
Looks like there is a syntax error related to 1.8, which we should kill anyway probably, but fwiw. Otherwise looks good to me. @lanej will leave for you to double check. Thanks! |
|
@geemus it would be great if we could kill 1.8 support sometime. Either way, that syntax error should be fixed, thanks for pointing it out. |
|
Agreed, we need to get rid of it. But for now, if they are small changes we should I guess make them just a little longer. |
lanej
reviewed
Mar 9, 2017
| @@ -36,31 +36,50 @@ def ready? | |||
| state == 'available' | |||
| end | |||
|
|
|||
| def save | |||
| raise Fog::Errors::Error.new('Resaving an existing object may create a duplicate') if persisted? | |||
There was a problem hiding this comment.
This case is no longer applicable?
There was a problem hiding this comment.
No, since if there is an identity, its going to call the modify_volume method instead of create_volume.
| @@ -63,7 +63,7 @@ def modify_volume(volume_id, options={}) | |||
| if options['Iops'] | |||
| volume_modification.merge!( | |||
| 'originalIops' => volume['iops'], | |||
| 'targetIops' => options['Iops'], | |||
| 'targetIops' => options['Iops'] | |||
|
Thanks!
…On Thu, Mar 9, 2017 at 4:02 PM, Josh Lane ***@***.***> wrote:
Merged #350 <#350>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#350 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAAQKneq4-zuS2enhRuRU_BHV-hge_1Jks5rkHcIgaJpZM4MUUfB>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.