Fix Fog::Compute::AWS::Images#all #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanej
requested changes
Jul 6, 2017
| @@ -75,7 +75,7 @@ def end_element(name) | |||
| @image[name] = false | |||
| end | |||
| when 'creationDate' | |||
| @image[name] = Time.parse(value) | |||
| @image[name] = Time.parse(value) if value | |||
There was a problem hiding this comment.
Need to check for a blank value ("" or nil) for the sake of Jruby.
|
Thanks!
…On Thu, Jul 6, 2017 at 1:12 PM, Josh Lane ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In lib/fog/aws/parsers/compute/describe_images.rb
<#375 (comment)>:
> @@ -75,7 +75,7 @@ def end_element(name)
@image[name] = false
end
when 'creationDate'
- @image[name] = Time.parse(value)
+ @image[name] = Time.parse(value) if value
Need to check for a blank value ("" or nil) for the sake of Jruby.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#375 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAQKrdpa1BgNdeOmalVYnxqsneinspfks5sLSOMgaJpZM4OP5Os>
.
|
eddiej
force-pushed
the
ej-fix-describe-images
branch
from
5b48296
to
740af29
Compare
Calling #all fails with the error: `Excon::Error::Socket: 25:28: FATAL: Document is empty (Nokogiri::XML::SyntaxError)`. This was because of the parser not handling nil creationDate values: ``` when 'creationDate' @image[name] = Time.parse(value) ``` This commit ensures nil `creationDate` fields are not parsed.
eddiej
force-pushed
the
ej-fix-describe-images
branch
from
740af29
to
66187d7
Compare
|
Changes made to accommodate Jruby. Tests passing. |
lanej
approved these changes
Jul 18, 2017
|
Thanks @eddiej |
|
Thanks!
…On Tue, Jul 18, 2017 at 11:48 AM, Josh Lane ***@***.***> wrote:
Thanks @eddiej <https://github.com/eddiej>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#375 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAQKql5hMQQknI_h9o-NhvRJVsdUVz-ks5sPOHagaJpZM4OP5Os>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Fog::Compute::AWS::Images#allfails with the error:Excon::Error::Socket: 25:28: FATAL: Document is empty (Nokogiri::XML::SyntaxError).This was because the parser was calling
Time.parseonnilcreationDate values:This commit ensures nil or blank
creationDatefields are not parsed. It also adds a test forFog::Parsers::Compute::AWS::DescribeImageswhich wasn't present before.Fixes #273.