Allow for AWS errors not specifying region #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you seeing that behavior on master or an older version? I think the case that would cause it has been fixed, such that it might not even encounter this any more, but I'm not sure. Could you double check your version and if it still occurs? Thanks! |
|
We're on 0.0.7 |
|
Hmm. I guess it must be yet-another-edge-case then. Thanks for double checking. |
geemus
added a commit
that referenced
this pull request
Jan 26, 2015
Allow for AWS errors not specifying region
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting
"undefined methodcaptures' for nil:NilClass"` when sending requests with the wrong region. This PR updates the error parsing to handle the case where a new region isn't specified (the comment above this line suggests only some errors explicitly provide it).