Add idempotent excon option to some route53 API calls #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geemus
added a commit
that referenced
this pull request
Jan 26, 2015
Add idempotent excon option to some route53 API calls
|
Thanks! |
| @@ -141,6 +141,7 @@ def change_resource_record_sets(zone_id, change_batch, options = {}) | |||
| body = %Q{<?xml version="1.0" encoding="UTF-8"?><ChangeResourceRecordSetsRequest xmlns="https://route53.amazonaws.com/doc/#{@version}/">#{changes}</ChangeResourceRecordSetsRequest>} | |||
| request({ | |||
| :body => body, | |||
| :idempotent => true, | |||
There was a problem hiding this comment.
is this ok for retries despite being a POST ?
There was a problem hiding this comment.
I wondered the same thing. Usually I would say no (post generally creates things). So far as I can tell this is more like a put (updating the record) and it just replaces values. So I think you could re-replace with the same values as often or as many times as you might want without negative impact. Definitely let me know if I misunderstood though.
There was a problem hiding this comment.
As it should be performed atomically, this must be idempotent as doc says.
There was a problem hiding this comment.
@josacar thanks for the further clarification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
idempotentattribute to underlying request calls to retry in case AWS throws a 400 error.Affected API calls: