Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: attach volume on #save, remove #server= #443

Merged
merged 2 commits into from
Apr 23, 2018
Merged

fix: attach volume on #save, remove #server= #443

merged 2 commits into from
Apr 23, 2018

Commits on Apr 19, 2018

  1. fix: attach volume on #save, remove #server= 

    s/service/server/ in Volume#save.  Fixes attaching after initialization.

Require users to call #attach(server, device) to attach a volume after
it's created.  Volume#server=(new_server) having a side-effect of
attaching a volume is confusing.

Volume#device set on #initialize will be lost when calling
Volume#wait_for in fog-core ~> 2.0.

BREAKING CHANGE

Volume#server= is removed.
    @lanej
    lanej committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    82e36a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. doc: provide useful error message when using Volume#server= 

    Direct users to use #attach
    @lanej
    lanej committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    1c938fb View commit details
    Browse the repository at this point in the history