Support weight round robin mock #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,6 +59,20 @@ def list_resource_record_sets(zone_id, options = {}) | |||
| end | |||
|
|
|||
| class Mock | |||
| def set_identified_records(record, zone, name) | |||
There was a problem hiding this comment.
I feel like the set here is potentially confusing. I imagine it to mean like "a set of objects", but I can't help but read it like "set a value". I feel like it might be clearer if it were just get_identified_records. What do you think?
|
Looks good overall, added one comment above. Also it looks like there are some failures on travis for the tests relating to |
|
the bug should be fixed |
geemus
added a commit
that referenced
this pull request
Apr 17, 2015
Support weight round robin mock
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.