[CIRCSTORE-526] Add ILR support for publishing batch request update events #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-storage into CIRCSTORE-521 # Conflicts: # ramls/request-queue-reordering.json # src/main/java/org/folio/service/request/RequestBatchResourceService.java # src/test/java/org/folio/rest/api/RequestBatchAPITest.java # src/test/java/org/folio/rest/support/matchers/DomainEventAssertions.java
|
|
|
||
| batchResourceService.executeBatchUpdate(allDatabaseOperations, onFinishHandler) | ||
| .compose(v -> eventPublisher.publishCreated(payload.getInstanceId(), payload)); | ||
| } | ||
|
|
||
| private RequestQueueReordering mapRequestsToPayload(List<Request> requests) { | ||
| var firstRequest = requests.get(0); |
There was a problem hiding this comment.
Suggested change
| var firstRequest = requests.get(0); | |
| var firstRequest = requests.iterator().next(); |
There was a problem hiding this comment.
Since we work with List in this method (not Collection), accessing an element by index will be more efficient for array-based implementation with constant time complexity O(1)
Comment on lines
+257
to
+258
| assertRequestQueueReorderingEvent(instanceId.toString(), | ||
| requestsSorted.get(1).getString("itemId"), List.of(firstRequestId, secondRequestId), TITLE); |
There was a problem hiding this comment.
m.b. it's a good idea to extract constants ?
There was a problem hiding this comment.
assertRequestQueueReorderingEvent is a universal method that is also applicable to queues with ITEM requestLevel requests
AntonAntonich
approved these changes
Sep 11, 2024
alexanderkurash
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: CIRCSTORE-526