[MODCON-130] - Adjust process to add ECS tenant with soft deleted functionality #140
Conversation
azizbekxm
changed the title
| } | ||
|
|
||
| private void validateExistTenant(TenantEntity tenant) { | ||
| if (Boolean.FALSE.equals(tenant.getIsDeleted()) || tenant.getIsDeleted() == null) { |
There was a problem hiding this comment.
basically lets write migration script to update all existing tenants with isDeleted=false, it will simplify our java code to avoid additional null checks
There was a problem hiding this comment.
I checked that, there is no any migration script need because default value will be set . Also, we didn't write migration script for is_central field
I have checked that defaultValue is being set after updating module
| @@ -59,7 +59,7 @@ | |||
| <changeSet id="MOCON-127@add-is-deleted-flag" author="azizbekxm"> | |||
| <addColumn tableName="tenant"> | |||
| <column name="is_deleted" type="boolean" defaultValueBoolean="false"> | |||
| <constraints unique="false" /> | |||
| <constraints unique="false" nullable="false"/> | |||
There was a problem hiding this comment.
this added because there shouldn't be null
|
|
||
| validateTenantForUpdateOperation(consortiumId, tenantId, tenantDto, existedTenant); | ||
| // isDeleted flag cannot be changed by put request | ||
| tenantDto.setIsDeleted(existedTenant.getIsDeleted()); |
There was a problem hiding this comment.
After found issue relate to ablitiy of updating isCentral and isDeleted field, introduced improvement in order to prevent future unwanted changes
|
Purpose
https://issues.folio.org/browse/MODCON-127
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.