[MODCON-148] - removed tenantName from userTenant dto & change serialization inclusing from NON_EMPTY to NON_NULL

[azizbekxm]

Also we changed serialization level from NOT_EMPTY to NOT_NULL
https://github.com/folio-org/mod-consortia/pull/149/files#diff-5bce3498556598073fd13ac15d74be95386d8743acfd9f190f8fc03de4a37172L50

Purpose

https://folio-org.atlassian.net/browse/MODCON-148
Found issue

8:15:04 http-nio-8081-exec-5 [] [] [] [] ERROR DirectJDKLog         Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed: feign.FeignException$UnprocessableEntity: [422 Unprocessable Entity] during [POST] to [http://user-tenants] [UserTenantsClient#postUserTenant(UserTenant)]: [{"errors":[{"message":"Unrecognized field \"tenantName\" (class org.folio.rest.jaxrs.model.UserTenant), not marked as ignorable (11 known properties: \"barcode\", \"tenantId\", \"userId\", \"phoneNumb... (572 bytes)]] with root cause
feign.FeignException$UnprocessableEntity: [422 Unprocessable Entity] during [POST] to [http://user-tenants] [UserTenantsClient#postUserTenant(UserTenant)]: [{"errors":[{"message":"Unrecognized field \"tenantName\" (class org.folio.rest.jaxrs.model.UserTenant), not marked as ignorable (11 known properties: \"barcode\", \"tenantId\", \"userId\", \"phoneNumb... (572 bytes)]
	at feign.FeignException.clientErrorStatus(FeignException.java:242) ~[feign-core-13.1.jar!/:?]
	at feign.FeignException.errorStatus(FeignException.java:203) ~[feign-core-13.1.jar!/:?]
	at feign.FeignException.errorStatus(FeignException.java:194) ~[feign-core-13.1.jar!/:?]
	at feign.codec.ErrorDecoder$Default.decode(ErrorDecoder.java:103) ~[feign-core-13.1.jar!/:?]
	at feign.InvocationContext.decodeError(InvocationContext.java:126) ~[feign-core-13.1.jar!/:?]

Approach

After found incompatibility between user_tenant in mod-users and user_tenant in consortia

TODOS and Open Questions

Learning

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

• Does this PR meet or exceed the expected quality standards?
  • Code coverage on new code is 80% or greater
  • Duplications on new code is 3% or less
  • There are no major code smells or security issues
• Does this introduce breaking changes?
  • Were any API paths or methods changed, added or removed?
  • Were there any schema changes?
  • Did any of the interface versions change?
  • Were permissions changed, added or removed?
  • Are there new interface dependencies?
  • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

• What other modules will these changes impact?
• Do JIRAs exist to update the impacted modules?
  • If not, please create them
  • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
  • Do they have all the appropriate links to blocked/related issues?
• Are the JIRAs under active development?
  • If not, contact the project's PO and make sure they're aware of the urgency.
• Do PRs exist for these changes?
  • If so, have they been approved?
• Did you modify code to call some additional endpoints?
  • If so, do you check that necessary module permission added in ModuleDescriptor-template.yaml file?

Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud