MODDICONV-365: Automatically migration preparation for already migrated envs. #49
Conversation
Aliaksandr-Fedasiuk
requested review from
okolawole-ebsco,
VRohach,
dmytrokrutii,
KaterynaSenchenko,
RuslanLavrov,
JavokhirAbdullayev,
RomanChernetskyi and
Maksat-Galymzhan
mod-di-converter-storage-server/src/main/java/org/folio/dao/association/ProfileWrapperDao.java
Show resolved
Hide resolved
| .onFailure(th -> LOGGER.error("migrateDataImportProfiles:: Something happened during the profile migration", th)); | ||
| .onFailure(th -> { | ||
| LOGGER.error("migrateDataImportProfiles:: Something happened during the profile migration", th); | ||
| throw new CompletionException(th); |
There was a problem hiding this comment.
why throw this? I don't think onFailure needs a return object.
There was a problem hiding this comment.
Fixed, thanks
|
I like these changes. Using the metadata_internal table is good as well! |
| To check the results of the migration. Could be remove after migration. | ||
| */ | ||
| drop table if exists snapshots_new; | ||
| create table snapshots_new as |
There was a problem hiding this comment.
I think this is still using the get_profile_snapshot function is still using the old version and not one that uses wrapperId. So it would contain the same information as snapshot_old.
There was a problem hiding this comment.
Thanks, @okolawole-ebsco, I moved the creation of snapshot_new into the latest script.
|
@Aliaksandr-Fedasiuk Is it expected that link on raml-storage is updated in the PR ? |
thanks @VRohach, fixed |
| }, | ||
| { | ||
| "tableName": "metadata_internal", | ||
| "fromModuleVersion": "mod-di-converter-storage-2.2.0", |
There was a problem hiding this comment.
should the version here be 2.1.7?
There was a problem hiding this comment.
@KaterynaSenchenko, thanks! fixed
|
Purpose
Migration will start automatically only when profile_wrappers table is empty.
Approach
The script to clean table was added
Learning
MODDICONV-365