Skip to content

Commit

Permalink
[MODINV-1070] Code review
Browse files Browse the repository at this point in the history
  • Loading branch information
SerhiiNosko committed Aug 28, 2024
1 parent ddb33eb commit 638f9d9
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions src/main/java/org/folio/inventory/resources/TenantItems.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import java.util.Optional;
import java.util.concurrent.CompletableFuture;

import org.apache.http.HttpStatus;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.folio.TenantItemPair;
Expand All @@ -34,9 +35,13 @@
import io.vertx.ext.web.client.WebClient;
import io.vertx.ext.web.handler.BodyHandler;

/**
* Resource that allows to get Inventory items from multiple tenants at once.
* User should have an affiliation in order to be able to retrieve items from the corresponding tenant.
*/
public class TenantItems {

private static final Logger log = LogManager.getLogger(MethodHandles.lookup().lookupClass());
private static final Logger LOG = LogManager.getLogger(MethodHandles.lookup().lookupClass());

private static final String TENANT_ITEMS_PATH = "/inventory/tenant-items";
public static final String ITEMS_FIELD = "items";
Expand Down Expand Up @@ -77,7 +82,7 @@ private void getItemsFromTenants(RoutingContext routingContext) {
}

private CompletableFuture<List<JsonObject>> getItemsWithTenantId(String tenantId, List<String> itemIds, RoutingContext routingContext) {
log.info("getItemsWithTenantId:: Fetching items - {} from tenant - {}", itemIds, tenantId);
LOG.info("getItemsWithTenantId:: Fetching items - {} from tenant - {}", itemIds, tenantId);
var context = new WebContext(routingContext);
CollectionResourceClient itemsStorageClient;
try {
Expand All @@ -98,7 +103,7 @@ private CompletableFuture<List<JsonObject>> getItemsWithTenantId(String tenantId
}

private List<JsonObject> getItemsWithTenantId(String tenantId, Response response) {
if (response.getStatusCode() != 200 || !response.hasBody()) {
if (response.getStatusCode() != HttpStatus.SC_OK || !response.hasBody()) {
return List.of();
}
return JsonArrayHelper.toList(response.getJson(), ITEMS_FIELD).stream()
Expand Down

0 comments on commit 638f9d9

Please sign in to comment.