Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR-1709 Implement NCIP RequestItem function in FOLIO mod-ncip #102

Merged
merged 37 commits into from
Sep 4, 2024
Merged

PR-1709 Implement NCIP RequestItem function in FOLIO mod-ncip #102

merged 37 commits into from
Sep 4, 2024

Conversation

JanisSaldabols
Copy link
Contributor

This PR is including multiple implementations
Most important are these:

  • PR-1709 Implement NCIP RequestItem function in FOLIO mod-ncip
  • PR-1786 Implement NCIP CancelRequestItem
  • PR-1785 Implement NCIP DeleteItem
  • PR-1814 Check user pin
  • PR-1861 Implement CreateUserFiscalTransaction for charging fees
  • PR-1910 Add item soft delete option

Also in responses we have added more return fields so that item, request, loan and fee can be linked to ILL request

ihardy and others added 30 commits September 4, 2024 09:22
@ihardy @JanisSaldabols
open development branch
d060db6
@JanisSaldabols
PR-1709 Implement NCIP RequestItem function
b73ec84
@JanisSaldabols
PR-1709 Fix problem with missing Scheme attribute
3a395c5
@JanisSaldabols
PR-1709 Add other scheme class
b88bc5f
@JanisSaldabols
PR-1709 Add option to make title level request
677d278
@JanisSaldabols
PR-1709 Make valid response with all mandatory fields
8e0bfdf
@JanisSaldabols
PR-1709 Use user barcode for request item
5b5cb73
@JanisSaldabols
PR-1709 Log properties
b1a1a18
@JanisSaldabols
PR-1709 Log properties
700f9c6
@JanisSaldabols
PR-1709 remove properties logging
d17441e
@JanisSaldabols
PR-1758 Set service point by code
1f61090
@JanisSaldabols
PR-1758 Use pickup location to set service point
fd1baee
@JanisSaldabols
PR-1776 Return loan id on check out
77b42fb
@JanisSaldabols
PR-1777 Return requester id in request item call
ba5046d
@JanisSaldabols
PR-1781 Return loan id, user id and fix request id
5a0c3f2
@JanisSaldabols
PR-1786 Implement NCIP CancelRequestItem
d8d533b
@JanisSaldabols
PR-1786 Implement NCIP CancelRequestItem
aac39db
@JanisSaldabols
PR-1786 Implement NCIP CancelRequestItem
034fd7a
@JanisSaldabols
PR-1786 Try to fix missing entity
c51dfca
@JanisSaldabols
PR-1786 Add integration test
05975b8
@JanisSaldabols
PR-1786 Rename for maven to pass
4e7ccfe
@JanisSaldabols
PR-1786 Return item id
30e8e59
@JanisSaldabols
PR-1785 Implement NCIP DeleteItem
9cfc3c6
@JanisSaldabols
PR-1785 Implement NCIP DeleteItem
4696282
@JanisSaldabols
PR-1814 Check user pin
893c165
@JanisSaldabols
PR-1821 Add default patron fee option (#27)
225485f
@JanisSaldabols
PR-1861 Implement CreateUserFiscalTransaction for charging fees (#29)
c045244
@JanisSaldabols
PR-1861 Return user UUID and Fee UUID (#31)
8fb83c2
@JanisSaldabols
PR-1876 Add item ID to fee in barcode
fe40253
@JanisSaldabols
PR-1906 Add ILL request id to ILS request and loan
246cee8
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JanisSaldabols JanisSaldabols marked this pull request as draft September 4, 2024 10:10
@JanisSaldabols JanisSaldabols marked this pull request as ready for review September 4, 2024 10:10
@JanisSaldabols JanisSaldabols merged commit be3516b into folio-org:master Sep 4, 2024
3 checks passed
@JanisSaldabols JanisSaldabols deleted the PR-1709-dev branch September 4, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mis306lu mis306lu mis306lu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JanisSaldabols @mis306lu @ihardy