Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for flowing text always appending a new page #1256

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Simolation
Copy link
Contributor

@Simolation Simolation commented May 29, 2021

When creating implicit rows by positioning the text at specific points the auto text overflow to the next page always added a new page at the end. Thus, it was not possible to create custom column layouts as the text should wrap to the next page when the document end is not reached.

Bugfix
#1201

What kind of change does this PR introduce?
Allows text to flow to the following page when the current page is followed by another existing page. Only when the document end is reached it will append a new page

Checklist:

  • Visual Tests
  • Documentation N/A
  • Update CHANGELOG.md
  • Ready to be merged

I added visual tests to demonstrate the behavior

@blikblum
Copy link
Member

@liborm85 @devongovett any comments on this change?

@Lectem
Copy link

Lectem commented Apr 19, 2022

Any update on this ?
We have the same issue where making a text columns layout is an issue.

@doublepithre
Copy link

Hope to see updates on this.

@kbouchard
Copy link

kbouchard commented Oct 17, 2023

Is there any progress on this issue / PR ?
We've forked pdfkit and have been using this branch for 2 years now. It did fix our issue and did not create new ones so I am wondering what we could do to get this reviewed/tested and merged?

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants