Fix reading cmap table
#276
Conversation
The data offset must be saved before parsing one entry and restored thereafter. Otherwise only the first table is parsed properly, and garbage is returned for the rest. Fails on i.e. georgiai.ttf. When reading the glyphIds, divide count by 2 (we read 16-bit words).
|
Great, thanks for the patch! |
|
Hey guys, thanks for your work on makePDF, it seems to be the PDF solution I was looking for. However, I’ve been stuck for a couple of weeks trying to get Times New Roman into my pdfMake file. I posted a full explanation of my my problem on bpampuch/pdfmake#33, but in a nutshell: I believe I have successfully completed steps 1, 2, and 3 for using custom fonts (creating a new version of vfs_fonts.js containing Times New Roman using grunt dump_dir, defining my font family, and changing my font family in doc-definition-object), but am still receiving the error: “Uncaught Error: No unicode cmap for font — pdfmake.js: 30835”. There was some discussion on bpampuch/pdfmake#18 that this error resulted from using pdfmake.min.js, but could be avoided if one used the non-min’ed version: pdfmake.js, but i am using the non-min’ed version and am still receiving the error. It looks like this patch may solve my problem, but I have never worked with coffeescript and am a little confused. My project is a site that, thus far, uses only html, javascript, css, and php. What do I do with the snippet in “Files changed” - am I supposed to add the coffeescipt to pdfmake.js, and if so, where? Thanks for your help! |
The data offset must be saved before parsing one entry and restored
thereafter. Otherwise only the first table is parsed properly, and garbage
is returned for the rest. Fails on i.e. georgiai.ttf.
When reading the glyphIds, divide count by 2 (we read 16-bit words).