Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: lazy.nvim plugin does not respect version = '*' when updating itself. #260

Closed
3 tasks done
tysonliddell opened this issue Dec 31, 2022 · 1 comment · Fixed by #251
Closed
3 tasks done

bug: lazy.nvim plugin does not respect version = '*' when updating itself. #260

tysonliddell opened this issue Dec 31, 2022 · 1 comment · Fixed by #251
Labels
bug Something isn't working

Comments

@tysonliddell
Copy link

tysonliddell commented Dec 31, 2022

Did you check docs and existing issues?

  • I have read all the lazy docs
  • I have searched the existing issues of lazy
  • I have searched the exsiting issues of the plugin I have a problem with

Neovim version (nvim -v)

NVIM v0.8.1

Operating system/version

MacOS 12.8

Describe the bug

With theversion = '*' option is set, running :Lazy update results in the lazy.nvim plugin updating to the latest (potentially unstable) commit, rather than the latested tagged commit. This only happens for the lazy.nvim plugin itself. All other plugins where I have specified version = '*' remain at the latest tagged releases as expected.

Steps To Reproduce

require("lazy").setup({
    { 'folke/lazy.nvim', version = '*' }
})

Expected Behavior

At the time of writing, I would expect :Lazy update to update lazy.nvim to version a2f5c51 (v7.6.0) when version = '*' is set for the plugin, but it instead updates to the newer, unstable commit d02a10d.

My current workaround is to use tag = 'stable' instead of version, which causes lazy.nvim to remain at the stable commit a2f5c51.

Repro

No response

@tysonliddell tysonliddell added the bug Something isn't working label Dec 31, 2022
@folke folke closed this as completed in 865ff41 Dec 31, 2022
@folke
Copy link
Owner

folke commented Dec 31, 2022

Good catch!!

I didn't support packed-refs yet, so other version might've also been broken. Although weirdly enough, specifying --single-branch on clone fetched the real tags instead of the packed-refs. The bootstrap command did not include that.

Anyway, this is no longer needed, since I now also read packed-refs.

I'll make a new release so that from then on, version will be properly respected in all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants