Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: plugin updates do not update existing tags #264

Closed
3 tasks done
tysonliddell opened this issue Dec 31, 2022 · 4 comments · Fixed by #265
Closed
3 tasks done

bug: plugin updates do not update existing tags #264

tysonliddell opened this issue Dec 31, 2022 · 4 comments · Fixed by #265
Labels
bug Something isn't working

Comments

@tysonliddell
Copy link

Did you check docs and existing issues?

  • I have read all the lazy docs
  • I have searched the existing issues of lazy
  • I have searched the exsiting issues of the plugin I have a problem with

Neovim version (nvim -v)

NVIM v0.8.1

Operating system/version

MacOS 12.8

Describe the bug

I am using { 'folke/lazy.nvim', tag = 'stable' } as a temporary workaround for #260. This morning when I did :Lazy update, it did not update to the latest stable version v7.7.0 (cba99de). Doing a git log in ~/.local/share/nvim/lazy/lazy.nvim, I observed that while the latest cba99de commit is present in the tree, the stable tag had not been updated. I suspect the cause is related to the following:

$ git fetch --all --tags
From https://github.com/folke/lazy.nvim
 ! [rejected]        stable     -> stable  (would clobber existing tag)

Steps To Reproduce

require("lazy").setup({
  { 'folke/lazy.nvim', tag = 'stable' },
})

Expected Behavior

I would expect setting tag = stable in the config would result in the tag being updated when it changes in the plugin repo, and hence the plugin updating to what is now stable.

Repro

No response

@tysonliddell tysonliddell added the bug Something isn't working label Dec 31, 2022
@folke
Copy link
Owner

folke commented Dec 31, 2022

Use version=* instead

@tysonliddell
Copy link
Author

tysonliddell commented Dec 31, 2022

I am now. Does this tag behaviour need to be fixed?

@folke
Copy link
Owner

folke commented Dec 31, 2022

The problem is that the stable tag for lazy gets updated after every release.
Lazy would not do an update when tag=stable, since the local repo would already be on stable.

@folke
Copy link
Owner

folke commented Dec 31, 2022

Will fix it so it also works in that case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants