Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with rhysd/committia.vim #35

Closed
tsakirist opened this issue Dec 20, 2022 · 6 comments · Fixed by #30
Closed

Doesn't work with rhysd/committia.vim #35

tsakirist opened this issue Dec 20, 2022 · 6 comments · Fixed by #30
Labels
bug Something isn't working

Comments

@tsakirist
Copy link
Contributor

tsakirist commented Dec 20, 2022

Describe the bug
I'm not sure if this should be opened in https://github.com/rhysd/committia.vim or in here.
After moving 99% of my plugins only this one is left which doesn't seem to be working, whether it's lazy-loaded or not.

Which version of Neovim are you using?
Neovim nightly latest

To Reproduce
Steps to reproduce the behavior:

  1. Install Lazy
  2. Add https://github.com/rhysd/committia.vim to plugins
  3. Open git commit view (git commit some staged files)

Expected Behavior
committia should be loaded and enabled in the git-commit buffer. (With packer it works)

@tsakirist tsakirist added the bug Something isn't working label Dec 20, 2022
@tsakirist tsakirist changed the title Doesn't work with https://github.com/rhysd/committia.vim Doesn't work with rhysd/committia.vim Dec 20, 2022
@folke
Copy link
Owner

folke commented Dec 20, 2022

Have never used this plugin myself. Can you provide me with an example spec I can use to debug? OR is it just the repo?

@tsakirist
Copy link
Contributor Author

Yes just use only the repo

@tsakirist
Copy link
Contributor Author

tsakirist commented Dec 20, 2022

If I remember correctly this plugin adds some autocommands for BufRead event to determine whether or not it should open.

This is from another issue, but explains how it works: rhysd/committia.vim#56 (comment)

@folke folke closed this as completed in ffcd0ab Dec 20, 2022
@folke
Copy link
Owner

folke commented Dec 20, 2022

Should be fixed now!

@tsakirist
Copy link
Contributor Author

Should be fixed now!

Seems to be working only when it's not lazy-loaded though.
If I lazy-load it doesn't work:

{
    "rhysd/committia.vim",
    ft = "gitcommit",
    config = function()
        vim.g.committia_min_window_width = 140
        vim.g.committia_edit_window_width = 90
    end,
},

@clason
Copy link
Collaborator

clason commented Dec 20, 2022

Do not load filetype plugins lazily. They should take care of this themselves, and often require some (minimal) setup before the filetype is set.

uhooi added a commit to uhooi/dotfiles that referenced this issue May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants