Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: manage message state without msg_clear #209

Merged
merged 9 commits into from
Nov 10, 2022
Merged

feat: manage message state without msg_clear #209

merged 9 commits into from
Nov 10, 2022

Conversation

folke
Copy link
Owner

@folke folke commented Nov 10, 2022 •
edited
Loading

Message state is currently managed Neovim msg_clear events, which lead to all sorts of problems, since Noice is more than just Neovim messages.

The new implementation no longer uses msg_clear events.

Incoming messages are now routed directly to the correct views. Views manage message state:

  • notify/mini: clear messages once the message has been dispatched into the view
  • nui views: clear messages on close of the view

@folke folke marked this pull request as ready for review November 10, 2022 17:32
This was linked to issues Nov 10, 2022
split window closes on match #198
Closed
Don't use msg_clear to determine message state #164
Closed
@folke folke merged commit fb0e3b0 into main Nov 10, 2022
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

split window closes on match Don't use msg_clear to determine message state
1 participant
@folke