Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noice is currently broken on Nightly (fixed) #298

Closed
2 tasks done
folke opened this issue Jan 1, 2023 · 16 comments · Fixed by #313 or #639
Closed
2 tasks done

Noice is currently broken on Nightly (fixed) #298

folke opened this issue Jan 1, 2023 · 16 comments · Fixed by #313 or #639
Labels
bug Something isn't working

Comments

@folke
Copy link
Owner

folke commented Jan 1, 2023

The big tui rework has been merged, which is really cool and will eventually make Noice work even better.

However, at this moment, Noice is unstable on nightly.

Last commit that works with noice is neovim/neovim@99cf111

Issues

@dbalatero
Copy link

I've been meaning to check out noice but I'm also on nightly. Would you mind updating this issue/thread once everything's stabilized? Thanks!

@folke
Copy link
Owner Author

folke commented Jan 11, 2023

I will. For now it's just waiting till the linked issue is fixed

@crivotz
Copy link

crivotz commented Jan 12, 2023

I have the same problem as the linked issue by doing =G or gg=G or =% only in normal.
I will stay on the stable for now, thanks for the work

@kierun
Copy link

kierun commented Jan 12, 2023

Everyone here probably knows this… However, for anyone using bob: bob use 99cf111 will get you the last bleeding-edge version of Neovim before the bug.

@folke

This comment was marked as resolved.

@przepompownia
Copy link

No crash with the initial example from neovim/neovim#21604 (after update by Lazy) and in my regular environment 🎉

@surmish
Copy link

surmish commented Jan 13, 2023

Should LazyVim change to make version false for noice?

@folke
Copy link
Owner Author

folke commented Jan 13, 2023

@surmish I just released a new version, so you can just update LazyVim

@folke

This comment was marked as resolved.

@folke
Copy link
Owner Author

folke commented Jan 14, 2023

Together with @bfredl, we've been able to come up with a work-around for the Neovim crashes with Noice, so everything should pretty much work the same as it did before the TUI rework. You can ignore my comments above about impaired functionality. Everything should work again with a recent nightly.

If you would still experience crashes, please let me know in the comments.

image

@folke folke changed the title Noice is currently broken on Nightly Noice is currently broken on Nightly (fixed) Jan 14, 2023
@folke
Copy link
Owner Author

folke commented Jan 17, 2023

Are there any other macos users that still experience segfaults?
I'm running Linux and didn't have any segfault anymore since my fix.

See also:

@max397574
Copy link
Contributor

I didn't experience any

@przepompownia
Copy link

I still don't have regular crashes as such from neovim/neovim#21604

@folke
Copy link
Owner Author

folke commented Jan 17, 2023

@przepompownia you do have crashes or you don't? :)

@przepompownia
Copy link

Restricting the scope to described in the above Neovim bug I don't (we can stick to this scope here ;)) :)

In last days i got some crash after enter some input but I'm not sure if it was related to Noice or UI separation and I cannot reproduce it.

@camin-mccluskey
Copy link

@folke MacOS user here. Started to notice crashes in the last week or so. I assumed I was hitting some weird "quit all" keycombo (I'm fairly new to LazyVim). Dug in a bit today and realised they are SegV of the type mentioned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants