Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: messages from fugitive are not split correctly #483

Closed
3 tasks done
Shatur opened this issue May 27, 2023 · 2 comments · Fixed by #484 or #639
Closed
3 tasks done

bug: messages from fugitive are not split correctly #483

Shatur opened this issue May 27, 2023 · 2 comments · Fixed by #484 or #639
Labels
bug Something isn't working

Comments

@Shatur
Copy link

Shatur commented May 27, 2023

Did you check docs and existing issues?

  • I have read all the noice.nvim docs
  • I have searched the existing issues of noice.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.9.0

Operating system/version

ArchLinux

Describe the bug

https://github.com/tpope/vim-fugitive tends to produce big messages when using :G push. They looks look normal without noice.nvim, but with noice.nvim it looks like this:
изображение
I have an ultra-wide display and it takes all horizontal space 😄

Steps To Reproduce

  1. Install noice
  2. Install vim-fugitive
  3. Open a repo with unpushed commits or create a new one.
  4. Call :G push

Expected Behavior

The output is the same as in CLI.

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/noice.nvim",
  "tpope/vim-fugitive",
  "rcarriga/nvim-notify",
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
require('notify').setup({
  top_down = false,
})
require('noice').setup({})
@Shatur Shatur added the bug Something isn't working label May 27, 2023
@folke folke closed this as completed in 520a737 May 27, 2023
@folke
Copy link
Owner

folke commented May 27, 2023

I just pushed an update that now should properly deal with \r characters. Would be great if you could confirm it's fixed. Thanks!

@Shatur
Copy link
Author

Shatur commented May 27, 2023

Now works like a charm, thanks!

folke added a commit that referenced this issue May 27, 2023
willothy pushed a commit to willothy/noice.nvim that referenced this issue Aug 19, 2023
willothy pushed a commit to willothy/noice.nvim that referenced this issue Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants