-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Cursor jumps in cmdline - 4.5.0 (MacOS + Wezterm) #950
Comments
I need a proper repro. Not a LAzyVim install. Does the issue trigger with the provided repro? |
And like I said, please use a recent nightly to reproduce. |
Here is a repo just using minimal I am using Windows 11 Can reproduce with Wezterm and Windows 11 Repo: https://github.com/JustBarnt/nvim-noice-min
Edit: I also tested this in Alacritty as well which the issue also exists there as well. |
@JustBarnt I tried your minimal repo but could not reproduce. I'm using same version of Neovim like you on Linux Mint 21.3 and latest Kitty terminal. Here's a screencast showing the process Screencast_2024-09-18-19-12-50.webm |
@dpetka2001 Correct this appears to be an issue that seems limited to Mac OS and Windows for some reason. I can reproduce the issue within Wezterm and Windows Terminal I updated my original comment to clarify |
@folke Thanks for your reply.
Yes, it does. My apologies. In my haste, I forgot to update the instructions to say use the minimal repro. I have edited to correct this.
I also reproduced on nightly from Neovim's releases:
|
I'm also confirming that pinning noice to v4.4.7 makes the flickering behavior go away—in both stable and nightly Neovim:
|
Yes, I just tried with latest |
I'm also on linux. Will look into it tomorrow to see what's happening on Windows. I'm not going to revert to v4.4.7. The way that used to work was one big hack by hooking into redraw calls. |
@folke I actually think I just figured out the cause! Currently testing on Windows with all mentioned terminals! I just need someone to be able to test the PR within linux (to confirm there are no regressions) and on Mac to confirm it fixed it there as well |
I tested the linked PR locally and from my short testing I don't see any regression on Linux. Hope I didn't miss something. Folke obviously will have a better opinion on this. |
Yeah indeed, that But there's some thing I want to check first. |
Yeah setting cursor to false works as well. |
@JustBarnt what was the thing that you found to fix it? |
@folke I found that adding Not sure what the correct fix per say is. if not Util.is_search() then
if vim.api.nvim__redraw then
vim.api.nvim__redraw({ flush = true, cursor = true, win = Cmdline.win() })
else
vim.cmd.redraw()
end
end |
@JustBarnt that's also a good idea, but I think it's not really needed. I just pushed some changes, so would be great if everyone could check if the problem is now gone. |
Great :) The issue was due to a bad copy-paste I did from the cmdline code. Glad it's fixed! But still weird, that the problem didn't show on Linux. The code was indeed just wrong and I would have expected the cursor to be flickering between the real position and the cmdline. But for some reason that didn't happen on Linux. Probably some debounce somewhere specifc to Linux. |
🤖 I have created a release *beep* *boop* --- ## [4.5.1](v4.5.0...v4.5.1) (2024-09-18) ### Bug Fixes * dont redraw when exiting. Fixes [#936](#936). Fixes [#921](#921) ([8c6a024](8c6a024)) * **hacks:** dont close timer multiple times during exit ([86a4891](86a4891)) * **hacks:** only redraw cursor when cmdline is active. Fixes [#950](#950). Fixes [#937](#937). Fixes [#923](#923) ([3373ab5](3373ab5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Fix confirmed on my system, too. Thanks, @folke! |
@folke resolved the flickering issue. folke/noice.nvim#923 folke/noice.nvim#950
Did you check docs and existing issues?
Neovim version (nvim -v)
v0.10.1 Release
Operating system/version
MacOS 14.6.1
Describe the bug
Opening a new issue per this comment in #923.
Steps To Reproduce
:
Expected Behavior
The cursor stays rendered in the command prompt, and does not flicker around.
Repro
The text was updated successfully, but these errors were encountered: