refactor: remove the fix_input hack #585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also suspect this might be causing #566... |
|
Triggering Noice updates right before input is definitely still needed, but I'm ok with removing the cursor hiding part |
|
@folke thank you for the fix! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was probably added for a good reason in the past, but wrapping these input functions is now causing issues with other plugins (and as far as I was able to test, it doesn't seem necessary anymore?).
As an example,
mini.clueusesgetcharstrto get the next typed key, but it's problematic when using the submode feature. This is because when using submodes,mini.cluewill enter a kind of a "pending" mode until the submode is exited, butnoicehides the cursor while in such state.Removing this code didn't cause any noticeable problems locally.
noicealready hides the cursor when entering command-line mode, and even other plugins likebufferlineandflashall seem to work as expected.