Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the fix_input hack #585

Closed
wants to merge 1 commit into from
Closed

refactor: remove the fix_input hack #585

wants to merge 1 commit into from

Conversation

MariaSolOs
Copy link
Contributor

@MariaSolOs MariaSolOs commented Sep 3, 2023

This was probably added for a good reason in the past, but wrapping these input functions is now causing issues with other plugins (and as far as I was able to test, it doesn't seem necessary anymore?).

As an example, mini.clue uses getcharstr to get the next typed key, but it's problematic when using the submode feature. This is because when using submodes, mini.clue will enter a kind of a "pending" mode until the submode is exited, but noice hides the cursor while in such state.

Removing this code didn't cause any noticeable problems locally. noice already hides the cursor when entering command-line mode, and even other plugins like bufferline and flash all seem to work as expected.

@MariaSolOs
Copy link
Contributor Author

I also suspect this might be causing #566...

@folke
Copy link
Owner

folke commented Sep 25, 2023

Triggering Noice updates right before input is definitely still needed, but I'm ok with removing the cursor hiding part

@MariaSolOs
Copy link
Contributor Author

@folke thank you for the fix! <3

@MariaSolOs MariaSolOs deleted the input-hack branch September 25, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants