fix(markdown): increase regex pattern specificity #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostl1ght
changed the title
|
Sorry, but that's just not a valid code-block language. |
|
Well, default hover is not crashing with the same code block: IMO 'noice' should match that behavior. |
|
I'm fine with gracefully handling these types of errors, but not to fix bugs in a certain LSP. |
|
What do you mean by handling this error gracefully? Should noice send an error instead of trying to render a hover message if it has invalid markdown or do something else? Also, apparently it is not a rust-analyzer error but an error in that library's documentation 😅 |
folke
pushed a commit
that referenced
this pull request
Jul 17, 2024
🤖 I have created a release *beep* *boop* --- ## [4.4.3](v4.4.2...v4.4.3) (2024-07-16) ### Bug Fixes * **mini:** no need to show scrollbar ([c661f95](c661f95)) * **syntax:** prevent invalid group names. Closes [#903](#903) ([3b5ea55](3b5ea55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902