bug: snacks undo picker layout tree discrepancies

[Jacobus-afk]

Did you check docs and existing issues?

• I have read all the snacks.nvim docs
• I have updated the plugin to the latest version before submitting this issue
• I have searched the existing issues of snacks.nvim
• I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.10.3

Operating system/version

Ubuntu 24.04.1

Describe the bug

Thanks for all the hard work on snacks, the new pickers are amazing!

i used undotree to compare with the snacks undo picker, and picked up a few discrepencies.

On undotree the the undo sequences form 3 distinct paths (1-2-5, 1-3, 1-4), while on the undo picker, it's less clear (at least to me) exactly which undo sequences are linked.

Steps To Reproduce

Generate actions that can be undone

Expected Behavior

to be shone the different undo paths with the correct undo sequences linked to them when i open the undo picker

Repro

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
    spec = {
        { "folke/snacks.nvim", opts = {} },
        -- add any other plugins here
        { "mbbill/undotree" },
    },
})

[folke]

I had done the visualization similar to telescope-undo.nvim, but I agree that it could be improved.

I'm not a fan of how undotree.vim does it, since they combine the tree view while sorting by seq.
I find a little hard to follow the changes, so I did it slightly different.

See the examples below.

Snacks:

undotree.vim:

[folke]

There's a bug somewhere. Sorting isn't stable. Looking into it

[folke]

Fixed and I also made it much much faster for files with a large undo history.

The problem was that while processing the undo history, Neovim would constantly send change tracking
updates to the LSP, which slowed down everything.

Now I create a temp file (without ft) from the buffer and copy over its undo file.
Then I do all checks on the tmp file instead.

Added benefit is that the active buffer also won't show the processing.

[Jacobus-afk]

Thanks @folke, appreciate you!

Now I create a temp file (without ft) from the buffer and copy over its undo file.
Then I do all checks on the tmp file instead.

Was this also why the history on undotree disappeared when the snacks undo picker is opened?

[folke]

No, that's because undotree shows you the history of the current buffer. But if you have snacks open, the current buffer is the snacks picker, which doesn't have undo history of course

[Jacobus-afk]

ahh makes sense, thanks!