feat(terminal): add toggle_all() function
#421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollema
changed the title
toggle_all() function to terminal.lua
ollema
changed the title
toggle_all() function to terminal.luaterminal): add toggle_all() function
ollema
changed the title
terminal): add toggle_all() functiontoggle_all() function
|
uh I have no idea why that bot decided to nuke my change, I probably misunderstood how to configure that in my fork. removed the app now and force pushed the actual change |
ollema
force-pushed
the
main
branch
2 times, most recently
from
ddaefd2 to
f0c2d38
Compare
1 task
|
could potentially close #759 |
folke
pushed a commit
that referenced
this pull request
Feb 8, 2025
🤖 I have created a release *beep* *boop* --- ## [2.20.0](v2.19.0...v2.20.0) (2025-02-08) ### Features * **picker.undo:** `ctrl+y` to yank added lines, `ctrl+shift+y` to yank deleted lines ([3baf95d](3baf95d)) * **picker:** added treesitter symbols picker ([a6beb0f](a6beb0f)) * **terminal:** added `Snacks.terminal.list()`. Closes [#421](#421). Closes [#759](#759) ([73c4b62](73c4b62)) ### Bug Fixes * **explorer:** change grep in item dir keymap to leader-/. Closes [#1000](#1000) ([9dfa276](9dfa276)) * **layout:** take winbar into account for split layouts. Closes [#996](#996) ([e4e5040](e4e5040)) * **picker.git:** account for deleted files in git diff. Closes [#1001](#1001) ([e9e2e69](e9e2e69)) * **picker.git:** handle git status renames. Closes [#1003](#1003) ([93ad23a](93ad23a)) * **picker.lines:** use original buf instead of current (which can be the picker on refresh) ([7ccf9c9](7ccf9c9)) * **picker.proc:** don't close stdout on proc exit, since it might still contain buffered output. Closes [#966](#966) ([3b7021e](3b7021e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am enjoying the
terminalplugin quite a lot - but when I worked with more than one terminal I found it annoying to have to close all terminal windows one by one and then reopen them one by one.This PR adds a
toggle_all()function toterminal.luawhich opens all closed terminals (if any) or closes all opened terminals (if any). If no terminals have been opened, it will default to opening a new one (similar to theget()function).Maybe this could be implemented in userland but I could not find a nice way to do that. It also helps a lot to have access to the
terminalsvariable!Let me know what you think!
Screencast
In the following screencast I first toggle terminal 1 and then I toggle terminal 2.
I then use the newly added
toggle_allfunction to close and open both terminals with theCtrl-\keybind.Screen.Recording.2025-01-05.at.13.00.06.mov