fix: lsp diag creates ugly buffers for unopened files in the workspac…

…e. Fixed now
folke · Apr 22, 2021 · 91d1139 · 91d1139
1 parent 232c539
commit 91d1139
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/lua/trouble/lsp.lua b/lua/trouble/lsp.lua
@@ -17,6 +17,7 @@ local function preprocess_diag(diag, bufnr)
 
     ---@class Diagnostics
     ---@field is_file boolean
+    ---@field fixed boolean
     local ret
     ret = {
         bufnr = bufnr,

diff --git a/lua/trouble/view.lua b/lua/trouble/view.lua
@@ -1,8 +1,10 @@
 local renderer = require("trouble.renderer")
 local config = require("trouble.config")
 local folds = require("trouble.folds")
+local pfiletype = require('plenary.filetype')
 
 local highlight = vim.api.nvim_buf_add_highlight
+local buf_opt = vim.api.nvim_buf_get_option
 
 ---@class View
 ---@field buf number
@@ -142,7 +144,7 @@ function View:setup(opts)
     vim.api.nvim_exec([[
       augroup LspTroubleHighlights
         autocmd! * <buffer>
-        autocmd CursorMoved <buffer> lua require("trouble").action("preview")
+        autocmd CursorMoved <buffer> nested lua require("trouble").action("preview")
         autocmd BufEnter <buffer> lua require("trouble").action("on_enter")
         autocmd BufLeave <buffer> lua require("trouble").action("on_leave")
       augroup END
@@ -279,18 +281,34 @@ function View:jump(opts)
         View.switch_to(opts.win or self.parent, item.bufnr)
         vim.api.nvim_win_set_cursor(self.parent,
                                     {item.start.line + 1, item.start.character})
+
+        -- edit the buffer if it was a temp one
+        if item.fixed == true then
+            vim.cmd "e"
+            item.fixed = nil
+        end
     end
 end
 
--- TODO: nvim_open_window
 function View:preview()
     local item = self:current_item()
     if not item then return end
 
     if item.is_file ~= true then
         vim.api.nvim_win_set_buf(self.parent, item.bufnr)
         vim.api.nvim_win_set_cursor(self.parent,
-                                    {item.start.line, item.start.character})
+                                    {item.start.line + 1, item.start.character})
+        -- center the buffer vertically
+        vim.api.nvim_buf_call(item.bufnr, function() vim.cmd "norm! zz" end)
+
+        -- check if this is a temp buffer created by lsp diag
+        -- if so, then trigger BufRead to fix syntax etc
+        if item.fixed ~= true and buf_opt(item.bufnr, "buflisted") == false then
+            vim.api.nvim_buf_call(item.bufnr,
+                                  function() vim.cmd "do BufRead" end)
+            item.fixed = true
+        end
+
         clear_hl(item.bufnr)
         buffersHl[item.bufnr] = true
         for row = item.start.line, item.finish.line, 1 do