perf: prevent autocmd leaks

lua/trouble/config/highlights.lua

@@ -60,6 +60,7 @@ function M.setup()
   M.link(M.colors)
   M.source("fs")
   vim.api.nvim_create_autocmd("ColorScheme", {
+    group = vim.api.nvim_create_augroup("trouble.colorscheme", { clear = true }),
     callback = function()
       M._fixed = {}
     end,

lua/trouble/sources/diagnostics.lua

@@ -66,6 +66,7 @@ local cache = {}
 
 function M.setup()
   vim.api.nvim_create_autocmd("DiagnosticChanged", {
+    group = vim.api.nvim_create_augroup("trouble.diagnostics", { clear = true }),
     callback = function(event)
       -- NOTE: unfortunately, we can't use the event.data.diagnostics table here,
       -- since multiple namespaces exist and we can't tell which namespace the

lua/trouble/sources/lsp.lua

@@ -21,6 +21,7 @@ local M = {}
 
 function M.setup()
   vim.api.nvim_create_autocmd("LspAttach", {
+    group = vim.api.nvim_create_augroup("trouble.lsp.attach", { clear = true }),
     callback = function()
       Cache.symbols:clear()
     end,

lua/trouble/view/init.lua

@@ -44,7 +44,11 @@ function M.new(opts)
     self:on_mount()
   end
   self.opts.win.on_close = function()
-    M._last[self.opts.mode or ""] = self:at()
+    if not self.opts.auto_open then
+      for _, section in ipairs(self.sections) do
+        section:stop()
+      end
+    end
   end
 
   self.sections = {}
@@ -123,11 +127,6 @@ function M:on_mount()
   self:listen()
   self.win:on("WinLeave", function()
     Preview.close()
-    if not self.opts.auto_open then
-      for _, section in ipairs(self.sections) do
-        section:stop()
-      end
-    end
   end)
 
   local _self = Util.weak(self)

lua/trouble/view/section.lua

@@ -124,13 +124,18 @@ function M:main()
   return self._main
 end
 
+function M:augroup()
+  return "trouble.section." .. self.section.source .. "." .. self.id
+end
+
 function M:stop()
-  pcall(vim.api.nvim_del_augroup_by_name, "trouble-section-" .. self.id)
+  pcall(vim.api.nvim_del_augroup_by_name, self:augroup())
 end
 
 function M:listen()
   local _self = Util.weak(self)
-  local group = vim.api.nvim_create_augroup("trouble-section-" .. self.id, { clear = true })
+
+  local group = vim.api.nvim_create_augroup(self:augroup(), { clear = true })
   for _, event in ipairs(self.section.events or {}) do
     vim.api.nvim_create_autocmd(event.event, {
       group = group,

lua/trouble/view/window.lua

@@ -236,8 +236,8 @@ function M:check_alien()
 end
 
 function M:close()
-  self:augroup(true)
   pcall(vim.api.nvim_win_close, self.win, true)
+  self:augroup(true)
   self.win = nil
 end