Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lsp_incoming_calls provider #222

Closed
monopoly-db opened this issue Oct 19, 2022 · 6 comments · Fixed by #437
Closed

Add support for lsp_incoming_calls provider #222

monopoly-db opened this issue Oct 19, 2022 · 6 comments · Fixed by #437

Comments

@monopoly-db
Copy link

It'll be very useful to cycle through incoming calls by directly opening lsp_incoming_calls results in Trouble rather than having to do so by going to Telescope first.

@natdm
Copy link

natdm commented Jan 31, 2023

This would be great to see. Incoming and outgoing as well. Love trouble!

@shahamran
Copy link

Almost opened another feature request, requesting "call hierarchy".
Then I remembered that the technical name for it in LSP world is incoming_calls, and found this :)
So I'll add this comment here, both to show interest in this feature, and for the "call hierarchy" keyword to show up in search.

@folke
Copy link
Owner

folke commented May 19, 2024

I may add this to v3.

@folke
Copy link
Owner

folke commented May 30, 2024

Added!

@shahamran
Copy link

Awesome! thanks!

@shahamran
Copy link

Hi @folke, I tried it out, and it's not exactly what I expected from a call-hierarchy UI.

In such UI I expect the incoming calls entries to recursively have their parents in the tree as well. See: https://github.com/marcomayer/calltree.nvim.
This way you could easily see the "call stack" of a function you're inspecting, and quickly jump to any of its ancestors.

I thought that since trouble is a tree UI, it'd be a good fit for such use-case. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants